Baka-UpdatesManga
Manga Poll
What part of the world would you like to see represented more in manga/anime?
North Africa
South Africa
East Asia (excluding Japan)
Central Asia
South Asia
Southeast Asia
North America
Central America
South America
Eastern Europe
Western Europe
Middle East
Oceania
Antarctica
 
mascot
Manga is the Japanese equivalent of comics
with a unique style and following. the revolution! Read some manga today!

RSS Feed
Forums

Dark Mode Now Available 29321t

Pages (4Next
You must be ed to post!
From
Message Body
Post #808109
Post #808109
 avatar
Site


6 months ago
Posts: 2854

I updated the release highlighting page to add a color picker. Let me know if that provides a better experience. y27a


Member


6 months ago
Posts: 22

Quote from Manick

You can choose any color you want. Use the HTML color selector (it's RGB, #000000 to #FFFFFF in hex)

I didn't know that, thanks!.

I increased the brightness of the links slightly.

very very slightly indeed, but appreciated nevertheless, thanks again.

What are your concerns about the genre highlighting?

The colors seem to be too bright, at least the one i was using, now i will try to tweak the color i like with the tip you gave me.

Thank you again for your work!


Member


6 months ago
Posts: 22

Quote from Manick

I updated the release highlighting page to add a color picker. Let me know if that provides a better experience.

Oh dear, amazing! I just picked a color not too bright, so it would not be in stark contrast to the darker background.

Great job! (the color picker kinda reminded me of ye old windows for some reason xD)

Edit: i am sry, i am not the same since covid hit me (even with vaccine) ._. I made a mistake and i thought it wasn't working, but it runs perfectly. thank you very much.


... Last edited by melquiades 6 months ago
Post #808112
Post #808112
Member


6 months ago
Posts: 506

I have adjusted my filter colors so everything has dark text, but whatever metric you are currently using to determine filter text color is just making a lot of things illegible (eg #FF00FF should have black text, not white)


Post #kaloo
Post #kaloo
 avatar
Site


6 months ago
Posts: 2854

Is this on a series that is highlighted with multiple colors? Or just one? With multiple records I just used the first column so that the series name shows up well. This means that some of the text in the middle or to the right of the row might be difficult to see depending on your color selections.

Right now I'm using luminance, based on if it is greater than 50%. Do you have a better suggestion? Your color is right in the middle, so it should show up okay with black or white. If you would like, I can flip it so that stuff in the middle uses the other color.


... Last edited by Manick 6 months ago
Post #Manick
Post #Manick
Member


6 months ago
Posts: 13

Quote from Manick

I increased the brightness of the links slightly.

What are your concerns about the genre highlighting?

It's good now I think, might be best to just add a high contrast toggle (to the to-do list) that overwrites greys with lighter/darker shades of grey or just white/black, depending on the theme and colours in question.

Edit: a tech news site I use has had a built-in custom css option for years, many of us used it to implement dark mode (and much more) prior to their implementation of an official dark mode this year. They filtered some css changes they didn't allow (lol naturally we'd have blocked ads if possible) and we could subscribe to each other's shared css scripts. That last bit is a bit much, but if there's a custom css plug-in available already, then that might be worth looking into.


... Last edited by Figu 6 months ago
Member


6 months ago
Posts: 1

holy shit it finally happened, nice job!


Post #808125
Post #808125
 avatar
 Member


6 months ago
Posts: 1

This is awesome! I personally can't decide between light and dark mode yet, but I know many s favor using dark mode for their websites \ (-o-)/

(side note* the characters on the top banner look like apparitions on dark mode (^▽^) )


... Last edited by Yin_no 6 months ago
Post #Manick
Post #Manick
Member


6 months ago
Posts: 506

The nominal web standard for color contrast is to use "Relative Brightness"

So rather than the directly available Luminance you calculate from RGB with this formula, which will give you a value between 0 and 255.

L = 0.2126 * R + 0.7152 * G + 0.0722 * B


... Last edited by kaloo 6 months ago
Post #kaloo
Post #kaloo
 avatar
Site


6 months ago
Posts: 2854

That is the exact formula I'm using.

    // Calculate the relative luminance
    const luminance = 0.2126 * rgb.r + 0.7152 * rgb.g + 0.0722 * rgb.b;

    // Choose black or white based on luminance
    return luminance > 128 ? '#000000' : '#ffffff';


Post #808133
Post #808133
 avatar
Member


6 months ago
Posts: 420

While I don't really care about changing the color based on genre, would it be possible to add a feature where we could change the background color for the titles on the release page that are on our reading list or watch list (or any list, to be frank)?

The icons to indicate these items are a little small (they really have been ever since the site redesign), so the ability to change the background colors of these titles would really help to make it stand out when browsing the release page.


Post #Manick
Post #Manick
Member


6 months ago
Posts: 506

Sorry for assuming you were calculating that incorrectly.

Obviously you don't have to follow any particular web standard, but this is my day job so it bothered me. To hit a 4.5 contrast ratio this should be breaking around 45 rather than 128. Between 44.625 and 46.7~ works with black or white. (To hit the lower 3:1 contrast ratio it's between 25.5 and 76.5)


Post #kaloo
Post #kaloo
 avatar
Site


6 months ago
Posts: 2854

Quote from kaloo

Sorry for assuming you were calculating that incorrectly.

Not at all. Please lay some knowledge on me whenever you can.

Obviously you don't have to follow any particular web standard, but this is my day job so it bothered me. To hit a 4.5 contrast ratio this should be breaking around 45 rather than 128. Between 44.625 and 46.7~ works with black or white. (To hit the lower 3:1 contrast ratio it's between 25.5 and 76.5)

After playing around with the color picker and looking at contrast ratios, I changed it to 115. Let me know if this is better.


Post #Geese1
Post #Geese1
 avatar
Site


6 months ago
Posts: 2854

Quote from Geese1

While I don't really care about changing the color based on genre, would it be possible to add a feature where we could change the background color for the titles on the release page that are on our reading list or watch list (or any list, to be frank)?

I'll write it down. In the short term we've been focusing on outstanding requests that should have been done years ago (like dark mode), but we'll see how long it takes us to catch up.


Post #Manick
Post #Manick
 avatar
Member


6 months ago
Posts: 420

Quote from Manick

Quote from Geese1

While I don't really care about changing the color based on genre, would it be possible to add a feature where we could change the background color for the titles on the release page that are on our reading list or watch list (or any list, to be frank)?

I'll write it down. In the short term we've been focusing on outstanding requests that should have been done years ago (like dark mode), but we'll see how long it takes us to catch up.

Thanks; if/when you can get to it, it would be most appreciated.


Pages (4Next
You must be ed to post!